aboutsummaryrefslogtreecommitdiff
path: root/kernel/gcov
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2020-04-10 14:34:10 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2020-04-10 15:36:22 -0700
commitf4d74ef6220c1eda0875da30457bef5c7111ab06 (patch)
tree16f32d207bdd9c7bf6ad44c8d953d1207b8ec316 /kernel/gcov
parent3bfa7e141b0bbb818b25e0daafb65aee92e49ac4 (diff)
downloadlinux-stericsson-f4d74ef6220c1eda0875da30457bef5c7111ab06.tar.gz
kernel/gcov/fs.c: gcov_seq_next() should increase position index
If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Davidlohr Bueso <dave@stgolabs.net> Cc: Ingo Molnar <mingo@redhat.com> Cc: Manfred Spraul <manfred@colorfullife.com> Cc: NeilBrown <neilb@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Waiman Long <longman@redhat.com> Link: http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/gcov')
-rw-r--r--kernel/gcov/fs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index 5e891c3c2d93..82babf5aa077 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos)
{
struct gcov_iterator *iter = data;
+ (*pos)++;
if (gcov_iter_next(iter))
return NULL;
- (*pos)++;
return iter;
}