path: root/drivers
diff options
authorMikko Perttunen <mperttunen@nvidia.com>2018-06-29 17:38:14 +0300
committerStephen Boyd <sboyd@kernel.org>2018-07-08 16:56:24 -0700
commitf7b3182232c82bb9769e2d5471d702bae2972d2b (patch)
tree67cc3cbb61c7aa8798db2e9d47331a6bf0cabbbe /drivers
parentce397d215ccd07b8ae3f71db689aedb85d56ab40 (diff)
clk: tegra: bpmp: Don't crash when a clock fails to register
When registering clocks, we just skip any that fail to register (leaving a NULL hole in the clock table). However, our of_xlate function still tries to dereference each entry while looking for the clock with the requested id, causing a crash if any clocks failed to register. Add a check to of_xlate to skip any NULL clocks. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> Acked-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers')
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c
index a896692b74ec..01dada561c10 100644
--- a/drivers/clk/tegra/clk-bpmp.c
+++ b/drivers/clk/tegra/clk-bpmp.c
@@ -586,9 +586,15 @@ static struct clk_hw *tegra_bpmp_clk_of_xlate(struct of_phandle_args *clkspec,
unsigned int id = clkspec->args[0], i;
struct tegra_bpmp *bpmp = data;
- for (i = 0; i < bpmp->num_clocks; i++)
- if (bpmp->clocks[i]->id == id)
- return &bpmp->clocks[i]->hw;
+ for (i = 0; i < bpmp->num_clocks; i++) {
+ struct tegra_bpmp_clk *clk = bpmp->clocks[i];
+ if (!clk)
+ continue;
+ if (clk->id == id)
+ return &clk->hw;
+ }
return NULL;