path: root/kernel
diff options
authorSteven Rostedt (Red Hat) <srostedt@redhat.com>2013-03-05 10:53:02 -0500
committerSteven Rostedt <rostedt@goodmis.org>2013-03-07 10:31:38 -0500
commitc9960e48543799f168c4c9486f9790fb686ce5a8 (patch)
tree18ce6c645490604aa7c0ca9b74bdae36f44ed9c4 /kernel
parentd8741e2e88ac9a458765a0c7b4e6542d7c038334 (diff)
tracing: Do not return EINVAL in snapshot when not allocated
To use the tracing snapshot feature, writing a '1' into the snapshot file causes the snapshot buffer to be allocated if it has not already been allocated and dose a 'swap' with the main buffer, so that the snapshot now contains what was in the main buffer, and the main buffer now writes to what was the snapshot buffer. To free the snapshot buffer, a '0' is written into the snapshot file. To clear the snapshot buffer, any number but a '0' or '1' is written into the snapshot file. But if the file is not allocated it returns -EINVAL error code. This is rather pointless. It is better just to do nothing and return success. Acked-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel')
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 9e3120b8a2a..1f835a83cb2 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -4167,8 +4167,6 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt,
if (current_trace->allocated_snapshot)
- else
- ret = -EINVAL;