path: root/drivers
diff options
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>2013-01-06 11:10:44 +0100
committerJason Cooper <jason@lakedaemon.net>2013-01-06 17:53:28 +0000
commitdab9206445952e64213582b2ab9077972850d65b (patch)
tree92fe891f1fdcca9882523aa615fcdb809c3dc3b4 /drivers
parentab6e439fd07aba7cadcadb3fb5e11d3758e19679 (diff)
dma: mv_xor: fix error handling for clocks
When a channel fails to initialize, we release all ressources, including clocks. However, a XOR unit is not necessarily associated to a clock (some variants of Marvell SoCs have a clock for XOR units, some don't), so we shouldn't unconditionally be releasing the clock. Instead, just like we do in the mv_xor_remove() function, we should check if one clock was found before releasing it. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Diffstat (limited to 'drivers')
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index cc5d23d3add..e17fad03cb8 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -1366,8 +1366,11 @@ err_channel_add:
- clk_disable_unprepare(xordev->clk);
- clk_put(xordev->clk);
+ if (!IS_ERR(xordev->clk)) {
+ clk_disable_unprepare(xordev->clk);
+ clk_put(xordev->clk);
+ }
return ret;