path: root/arch/powerpc/platforms/pseries
diff options
authorMichael Ellerman <michael@ellerman.id.au>2009-01-22 20:54:31 +0000
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2009-02-11 13:38:01 +1100
commit3a51c0cbea947dc9194e18f11661eaa4dbfc5c13 (patch)
tree205b2b8694ec79d915deb185f36ad57b8399b184 /arch/powerpc/platforms/pseries
parente27ed698b88b3387d326e84c0bbe9f83e19c747b (diff)
powerpc/pseries: Add support for ibm,req#msi-x
Firmware encodes the number of MSI-X requested by a device in a different property than for MSI. Pull the property name out as a parameter and share the logic for both cases. Signed-off-by: Michael Ellerman <michael@ellerman.id.au> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/platforms/pseries')
1 files changed, 15 insertions, 5 deletions
diff --git a/arch/powerpc/platforms/pseries/msi.c b/arch/powerpc/platforms/pseries/msi.c
index 4af7aa3e2e0..acf1070d65c 100644
--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -132,7 +132,7 @@ static void rtas_teardown_msi_irqs(struct pci_dev *pdev)
-static int check_req_msi(struct pci_dev *pdev, int nvec)
+static int check_req(struct pci_dev *pdev, int nvec, char *prop_name)
struct device_node *dn;
struct pci_dn *pdn;
@@ -144,24 +144,34 @@ static int check_req_msi(struct pci_dev *pdev, int nvec)
dn = pdn->node;
- req_msi = of_get_property(dn, "ibm,req#msi", NULL);
+ req_msi = of_get_property(dn, prop_name, NULL);
if (!req_msi) {
- pr_debug("rtas_msi: No ibm,req#msi on %s\n", dn->full_name);
+ pr_debug("rtas_msi: No %s on %s\n", prop_name, dn->full_name);
return -ENOENT;
if (*req_msi < nvec) {
- pr_debug("rtas_msi: ibm,req#msi requests < %d MSIs\n", nvec);
+ pr_debug("rtas_msi: %s requests < %d MSIs\n", prop_name, nvec);
return -ENOSPC;
return 0;
+static int check_req_msi(struct pci_dev *pdev, int nvec)
+ return check_req(pdev, nvec, "ibm,req#msi");
+static int check_req_msix(struct pci_dev *pdev, int nvec)
+ return check_req(pdev, nvec, "ibm,req#msi-x");
static int rtas_msi_check_device(struct pci_dev *pdev, int nvec, int type)
if (type == PCI_CAP_ID_MSIX)
- pr_debug("rtas_msi: MSI-X untested, trying anyway.\n");
+ return check_req_msix(pdev, nvec);
return check_req_msi(pdev, nvec);