path: root/arch/arm/include/asm/bL_switcher.h
diff options
authorDave Martin <dave.martin@linaro.org>2013-05-22 19:08:16 +0100
committerNicolas Pitre <nicolas.pitre@linaro.org>2013-06-20 00:45:27 -0400
commit0e95b2814e880cb031550d7c812c622df37f9154 (patch)
tree557cd979ba66c346aca438d41c5b07001c8fe114 /arch/arm/include/asm/bL_switcher.h
parent4c9163c32280a10f214f39dc945c5400ef91cd49 (diff)
ARM: bL_switcher: Add switch completion callback for bL_switch_request()
There is no explicit way to know when a switch started via bL_switch_request() is complete. This can lead to unpredictable behaviour when the switcher is controlled by a subsystem which makes dynamic decisions (such as cpufreq). The CPU PM notifier is not really suitable for signalling completion, because the CPU could get suspended and resumed for other, independent reasons while a switch request is in flight. Adding a whole new notifier for this seems excessive, and may tempt people to put heavyweight code on this path. This patch implements a new bL_switch_request_cb() function that allows for a per-request lightweight callback, private between the switcher and the caller of bL_switch_request_cb(). Overlapping switches on a single CPU are considered incorrect if they are requested via bL_switch_request_cb() with a callback (they will lead to an unpredictable final state without explicit external synchronisation to force the requests into a particular order). Queuing requests robustly would be overkill because only one subsystem should be attempting to control the switcher at any time. Overlapping requests of this kind will be failed with -EBUSY to indicate that the second request won't take effect and the completer will never be called for it. bL_switch_request() is retained as a wrapper round the new function, with the old, fire-and-forget semantics. In this case the last request will always win. The request may still be denied if a previous request with a completer is still pending. Signed-off-by: Dave Martin <dave.martin@linaro.org> Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Diffstat (limited to 'arch/arm/include/asm/bL_switcher.h')
1 files changed, 9 insertions, 1 deletions
diff --git a/arch/arm/include/asm/bL_switcher.h b/arch/arm/include/asm/bL_switcher.h
index 914739d17e3..98427597828 100644
--- a/arch/arm/include/asm/bL_switcher.h
+++ b/arch/arm/include/asm/bL_switcher.h
@@ -15,7 +15,15 @@
#include <linux/compiler.h>
#include <linux/types.h>
-int bL_switch_request(unsigned int cpu, unsigned int new_cluster_id);
+typedef void (*bL_switch_completion_handler)(void *cookie);
+int bL_switch_request_cb(unsigned int cpu, unsigned int new_cluster_id,
+ bL_switch_completion_handler completer,
+ void *completer_cookie);
+static inline int bL_switch_request(unsigned int cpu, unsigned int new_cluster_id)
+ return bL_switch_request_cb(cpu, new_cluster_id, NULL, NULL);
* Register here to be notified about runtime enabling/disabling of