path: root/fs
diff options
authorLinus Torvalds <torvalds@linux-foundation.org>2013-10-31 15:43:02 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-10-31 15:43:02 -0700
commit358eec18243ac025b2eb0317ab52bd247e1b03c6 (patch)
tree551bb789fa555bd26851a6d43bd78c6c3a398d00 /fs
parent0baab4fd6de4beb3393e173b392038d01da54bec (diff)
vfs: decrapify dput(), fix cache behavior under normal load
We do not want to dirty the dentry->d_flags cacheline in dput() just to set the DCACHE_REFERENCED flag when it is already set in the common case anyway. This way the first cacheline of the dentry (which contains the RCU lookup information etc) can stay shared among multiple CPU's. This finishes off some of the details of all the scalability patches merged during the merge window. Also don't mark dentry_kill() for inlining, since it's the uncommon path and inlining it just makes the common path slower due to extra function entry/exit overhead. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/dcache.c b/fs/dcache.c
index 20532cb0b06..ae6ebb88cef 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -542,7 +542,7 @@ EXPORT_SYMBOL(d_drop);
* If ref is non-zero, then decrement the refcount too.
* Returns dentry requiring refcount drop, or NULL if we're done.
-static inline struct dentry *
+static struct dentry *
dentry_kill(struct dentry *dentry, int unlock_on_failure)
@@ -630,7 +630,8 @@ repeat:
goto kill_it;
- dentry->d_flags |= DCACHE_REFERENCED;
+ if (!(dentry->d_flags & DCACHE_REFERENCED))
+ dentry->d_flags |= DCACHE_REFERENCED;