aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2016-04-04 14:00:33 +0100
committerDavid Howells <dhowells@redhat.com>2016-06-15 10:15:08 +0100
commit1c1df86fad68dd7188ea498e796c9d2ede679421 (patch)
treefb55a51870f2fd71ba9fa551e207dadf7a7aec9e /net
parent1a70c05bad1383fdda95e713baee5f76c4726d24 (diff)
download96b-common-1c1df86fad68dd7188ea498e796c9d2ede679421.tar.gz
rxrpc: Don't assume anything about the address in an ICMP packet
Don't assume anything about the address in an ICMP packet in rxrpc_error_report() as the address may not be IPv4 in future, especially since we're just printing these details. Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/rxrpc/peer_event.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/net/rxrpc/peer_event.c b/net/rxrpc/peer_event.c
index 80de84257227..6ba798d6659e 100644
--- a/net/rxrpc/peer_event.c
+++ b/net/rxrpc/peer_event.c
@@ -120,8 +120,6 @@ void rxrpc_error_report(struct sock *sk)
struct rxrpc_local *local = sk->sk_user_data;
struct rxrpc_peer *peer;
struct sk_buff *skb;
- __be32 addr;
- __be16 port;
_enter("%p{%d}", sk, local->debug_id);
@@ -139,12 +137,6 @@ void rxrpc_error_report(struct sock *sk)
rxrpc_new_skb(skb);
- addr = *(__be32 *)(skb_network_header(skb) + serr->addr_offset);
- port = serr->port;
-
- _net("Rx UDP Error from %pI4:%hu", &addr, ntohs(port));
- _debug("Msg l:%d d:%d", skb->len, skb->data_len);
-
rcu_read_lock();
peer = rxrpc_lookup_peer_icmp_rcu(local, skb);
if (peer && !rxrpc_get_peer_maybe(peer))