path: root/fs/sysv/sysv.h
diff options
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2012-07-03 16:43:28 +0300
committerAl Viro <viro@zeniv.linux.org.uk>2012-07-22 23:58:12 +0400
commit9d46be294d12871adf4206f89168b14d27adb8b5 (patch)
tree6851c9f7d278bcf8a7cf01ac65f670dbb3aa95bf /fs/sysv/sysv.h
parenteee458936b52bd3a9ff0ff577313b637905fff08 (diff)
fs/sysv: stop using write_super and s_dirt
It does not look like sysv FS needs 'write_super()' at all, because all it does is a timestamp update. I cannot test this patch, because this file-system is so old and probably has not been used by anyone for years, so there are no tools to create it in Linux. But from the code I see that marking the superblock as dirty is basically marking the superblock buffers as drity and then setting the s_dirt flag. And when 'write_super()' is executed to handle the s_dirt flag, we just update the timestamp and again mark the superblock buffer as dirty. Seems pointless. It looks like we can update the timestamp more opprtunistically - on unmount or remount of sync, and nothing should change. Thus, this patch removes 'sysv_write_super()' and 's_dirt'. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/sysv/sysv.h')
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h
index 11b07672f6c5..0bc35fdc58e2 100644
--- a/fs/sysv/sysv.h
+++ b/fs/sysv/sysv.h
@@ -117,7 +117,6 @@ static inline void dirty_sb(struct super_block *sb)
if (sbi->s_bh1 != sbi->s_bh2)
- sb->s_dirt = 1;