path: root/drivers/media/platform/sti/delta
diff options
authorGustavo A. R. Silva <garsilva@embeddedor.com>2017-07-05 14:23:55 -0400
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-07-19 15:02:27 -0400
commit6ad33dec835693e38c1994cedbd3c404782e84fb (patch)
treebe787d9ba5e7536521fd015f93d445e5b22855c7 /drivers/media/platform/sti/delta
parent72c6efb0d3fb0eff8b13c14dfcebbd8e8e63c1e4 (diff)
media: tuners: remove unnecessary static in simple_dvb_configure()
Remove unnecessary static on local variable t_params. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; In the following log you can see the difference in the code size. Also, there is a significant difference in the bss segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 23314 3640 832 27786 6c8a drivers/media/tuners/tuner-simple.o after: text data bss dec hex filename 23257 3552 768 27577 6bb9 drivers/media/tuners/tuner-simple.o Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/platform/sti/delta')
0 files changed, 0 insertions, 0 deletions