diff options
authorSabrina Dubroca <sd@queasysnail.net>2018-10-28 09:33:10 +0100
committerDavid S. Miller <davem@davemloft.net>2018-10-28 19:26:42 -0700
commit07bddef9839378bd6f95b393cf24c420529b4ef1 (patch)
parente6ac075882b2afcdf2d5ab328ce4ab42a1eb9593 (diff)
macsec: let the administrator set UP state even if lowerdev is down
Currently, the kernel doesn't let the administrator set a macsec device up unless its lower device is currently up. This is inconsistent, as a macsec device that is up won't automatically go down when its lower device goes down. Now that linkstate propagation works, there's really no reason for this limitation, so let's remove it. Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") Reported-by: Radu Rendec <radu.rendec@gmail.com> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Signed-off-by: David S. Miller <davem@davemloft.net>
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index 6195b8edafc0..64a982563d59 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -2812,9 +2812,6 @@ static int macsec_dev_open(struct net_device *dev)
struct net_device *real_dev = macsec->real_dev;
int err;
- if (!(real_dev->flags & IFF_UP))
- return -ENETDOWN;
err = dev_uc_add(real_dev, dev->dev_addr);
if (err < 0)
return err;