aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSakari Ailus <sakari.ailus@linux.intel.com>2016-07-20 12:39:02 -0300
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-01-30 11:33:26 -0200
commitaa79a84f65b37785ff56b30dc808c88bbc25a91b (patch)
treeed3b5082b19e5ca3a2e669cc6abe77656df1bcde
parent91b619adeb3753dc8fdc9f6aef692701f88f7420 (diff)
download96b-common-aa79a84f65b37785ff56b30dc808c88bbc25a91b.tar.gz
[media] media: entity: Add debug information to graph walk
Use dev_dbg() to tell about the progress of the graph traversal algorithm. This is intended to make debugging of the algorithm easier. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
-rw-r--r--drivers/media/media-entity.c19
1 files changed, 18 insertions, 1 deletions
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index a9998b30143f..5640ca29da8c 100644
--- a/drivers/media/media-entity.c
+++ b/drivers/media/media-entity.c
@@ -321,6 +321,8 @@ void media_graph_walk_start(struct media_graph *graph,
graph->top = 0;
graph->stack[graph->top].entity = NULL;
stack_push(graph, entity);
+ dev_dbg(entity->graph_obj.mdev->dev,
+ "begin graph walk at '%s'\n", entity->name);
}
EXPORT_SYMBOL_GPL(media_graph_walk_start);
@@ -335,6 +337,10 @@ static void media_graph_walk_iter(struct media_graph *graph)
/* The link is not enabled so we do not follow. */
if (!(link->flags & MEDIA_LNK_FL_ENABLED)) {
link_top(graph) = link_top(graph)->next;
+ dev_dbg(entity->graph_obj.mdev->dev,
+ "walk: skipping disabled link '%s':%u -> '%s':%u\n",
+ link->source->entity->name, link->source->index,
+ link->sink->entity->name, link->sink->index);
return;
}
@@ -344,16 +350,23 @@ static void media_graph_walk_iter(struct media_graph *graph)
/* Has the entity already been visited? */
if (media_entity_enum_test_and_set(&graph->ent_enum, next)) {
link_top(graph) = link_top(graph)->next;
+ dev_dbg(entity->graph_obj.mdev->dev,
+ "walk: skipping entity '%s' (already seen)\n",
+ next->name);
return;
}
/* Push the new entity to stack and start over. */
link_top(graph) = link_top(graph)->next;
stack_push(graph, next);
+ dev_dbg(entity->graph_obj.mdev->dev, "walk: pushing '%s' on stack\n",
+ next->name);
}
struct media_entity *media_graph_walk_next(struct media_graph *graph)
{
+ struct media_entity *entity;
+
if (stack_top(graph) == NULL)
return NULL;
@@ -365,7 +378,11 @@ struct media_entity *media_graph_walk_next(struct media_graph *graph)
while (link_top(graph) != &stack_top(graph)->links)
media_graph_walk_iter(graph);
- return stack_pop(graph);
+ entity = stack_pop(graph);
+ dev_dbg(entity->graph_obj.mdev->dev,
+ "walk: returning entity '%s'\n", entity->name);
+
+ return entity;
}
EXPORT_SYMBOL_GPL(media_graph_walk_next);