aboutsummaryrefslogtreecommitdiff
path: root/kernel/irq/generic-chip.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2013-07-05 17:13:12 +0800
committerThomas Gleixner <tglx@linutronix.de>2013-07-05 11:39:25 +0200
commit002fca5df168922103a2bb52748f9984e6de80b2 (patch)
tree9742e650398d3f48d8cf2ebfe8868c14c778a44a /kernel/irq/generic-chip.c
parent5b8aae489a07ac7d5a2cb897d6ca1fddb0c0043a (diff)
downloadlinux-stericsson-002fca5df168922103a2bb52748f9984e6de80b2.tar.gz
genirq: generic chip: Use DIV_ROUND_UP to calculate numchips
The number of interrupts in a domain may be not divisible by the number of interrupts each chip handles. Integer division may truncate the result, thus use DIV_ROUND_UP to count numchips. Seems all users of irq_alloc_domain_generic_chips() in current code do not have this issue. I just found the issue while reading the code. Signed-off-by: Axel Lin <axel.lin@ingics.com> Cc: Grant Likely <grant.likely@linaro.org> Cc: Tony Lindgren <tony@atomide.com> Cc: Arnd Bergmann <arnd@arndb.de> Link: http://lkml.kernel.org/r/1373015592.18252.2.camel@phoenix Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/irq/generic-chip.c')
-rw-r--r--kernel/irq/generic-chip.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
index 1c39eccc1eaf..2f274f30b7e2 100644
--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -278,7 +278,7 @@ int irq_alloc_domain_generic_chips(struct irq_domain *d, int irqs_per_chip,
if (d->revmap_type != IRQ_DOMAIN_MAP_LINEAR)
return -EINVAL;
- numchips = d->revmap_data.linear.size / irqs_per_chip;
+ numchips = DIV_ROUND_UP(d->revmap_data.linear.size, irqs_per_chip);
if (!numchips)
return -EINVAL;