path: root/kernel/irq/cpuhotplug.c
diff options
authorThomas Gleixner <tglx@linutronix.de>2017-06-20 01:37:26 +0200
committerThomas Gleixner <tglx@linutronix.de>2017-06-22 18:21:16 +0200
commit735c09524d3e7c92315e8e2699a1b9acb4fb415c (patch)
treee2ca5ba2a741242fd9ac05a3a0155783a9e887a6 /kernel/irq/cpuhotplug.c
parent0dd945ff4647a1f29c6ae8f4f9a69c8f37c994cf (diff)
genirq/cpuhotplug: Dont claim success on error
In case the affinity of an interrupt was broken, a printk is emitted. But if the affinity cannot be set at all due to a missing irq_set_affinity() callback or due to a failing callback, the message is still printed preceeded by a warning/error. That makes no sense whatsoever. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Keith Busch <keith.busch@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Christoph Hellwig <hch@lst.de> Link: http://lkml.kernel.org/r/20170619235445.274852976@linutronix.de
Diffstat (limited to 'kernel/irq/cpuhotplug.c')
1 files changed, 4 insertions, 1 deletions
diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
index 705139831590..9c5521b247d5 100644
--- a/kernel/irq/cpuhotplug.c
+++ b/kernel/irq/cpuhotplug.c
@@ -37,11 +37,14 @@ static bool migrate_one_irq(struct irq_desc *desc)
c = irq_data_get_irq_chip(d);
if (!c->irq_set_affinity) {
pr_debug("IRQ%u: unable to set affinity\n", d->irq);
+ ret = false;
} else {
int r = irq_do_set_affinity(d, affinity, false);
- if (r)
+ if (r) {
pr_warn_ratelimited("IRQ%u: set affinity failed(%d).\n",
d->irq, r);
+ ret = false;
+ }
return ret;