aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/dgap
AgeCommit message (Collapse)Author
2014-07-15staging: dgap: remove dgap_newnode()Daeseok Youn
The dgap_newnode() is useless for creating new node. So just use kzalloc and set a type in case statement. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15staging: dgap: remove unused a parameter in dgap_gettok()Daeseok Youn
The "p" as parameter is unused. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15staging: dgap: fix a typo in dgap_gettok()Daeseok Youn
The "boar" should be "board". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15staging: dgap: remove unused case value in dgap_parsefile()Daeseok Youn
If rc is zero, this function will returns with an error and cannot reach switch-case statement. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15staging: dgap: remove redundant error value checkDaeseok Youn
The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check "retval" itself. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_tty_digisetcustombaud() Null checks in dgap_tty_digisetcustombaud() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch", "bd and "un". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_tty_digigetcustombaud() Null checks in dgap_tty_digigetcustombaud() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch" and "un". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_tty_digisetedelay() Null checks in dgap_tty_digisetedelay() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch", "bd and "un". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_set_modem_info() Null checks in dgap_set_modem_info() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch", "bd" and "un". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_tty_digigeta() Null checks in dgap_tty_digigeta() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch" and "un". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_tty_digiseta() Null checks in dgap_tty_digiseta() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch" and "bd" which are used in dgap_tty_digiseta(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: removes redundant null check and change the paramter for ↵Daeseok Youn
dgap_param() The dgap_param() has a paramter which is tty_struct and use variables in that struct. That variables which are "ch", "bd", "bs" and "un" do not need to check NULL so these statements are removed. And also change the parameter of this function because it is possible to let someone know what paramters are needed for this function. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: remove unused variable in dgap_param()Daeseok Youn
The "ts" is not used in dgap_param(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-11staging: dgap: redundant NULL and magic check in dgap_get_modem_info()Daeseok Youn
The "ch" is already checking in caller. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: removes redundant null check and change paramter for ↵Daeseok Youn
dgap_maxcps_room() Null checks for tty, un and ch are already done by caller, so replace parameter "tty" with "ch" and "un". Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: remove redundant NULL check in dgap_tty_init()Daeseok Youn
The brd is already checked by earlier function in dgap_init_one(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: use kzalloc instead of kmalloc/memsetDaeseok Youn
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: remove unused waitqueuesDaeseok Youn
dgap_dl_wait and kme_wait are not used in dgap. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: remove unneccessary dgap_init_pci() functionDaeseok Youn
The dgap_init_pci() calls only pci_register_driver(). It doesn't need to make a function for that. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: Adds a blank line after declarationDaeseok Youn
clean up checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: remove "return" statement in void functionDaeseok Youn
clean up checkpatch warning: WARNING: void function return statements are not generally useful Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: dgap: fixed "foo* bar should be foo * bar" in dgap.cDaeseok Youn
clean up checkpatch.pl error: ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-20staging: dgap: make dgap_found_board() return a brd pointerDaeseok Youn
Make dgap_found_board() return a brd pointer and that brd pointer assign to dgap_board[] in the end of the dgap_init_one(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: unwind on error in dgap_init_one()Daeseok Youn
The dgap_init_one() needs to handle error properly if one of functions in dgap_init_one() is failed. Introduce some functions for handling error in dgap_init_one() - dgap_tty_unregister() : unregister tty driver - dgap_free_flipbuf() : free flip buffer - dgap_release_remap() : release memory region and unmapped memory. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: move unrelated functions in dgap_firmware_load()Daeseok Youn
The dgap_firmware_load() has a lot of stuff which are unrelated with loading firmware. So just moved to dgap_init_one(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: rename dgap_after_config_loaded() to dgap_alloc_flipbuf()Daeseok Youn
dgap_after_config_loaded() as function name doesn't tell what it does. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: introduce dgap_free_irq()Daeseok Youn
dgap_free_irq() will free the irq which is requested in dgap_request_irq(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: introduce dgap_tty_free() for freeing channels.Daeseok Youn
It should be called after dgap_tty_register_ports() is failed. So channels which are allocated in dgap_tty_init() will be freed. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: get rid of brd->firstminor because it is 0Daeseok Youn
firstminor in struct borad_t is always zero, so it can be removed. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: remove unused paramter in dgap_parsefile()Daeseok Youn
"remove" parameter is not used in dgap_parsefile(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: rename dgap_tty_uninit() to dgap_cleanup_tty()Daeseok Youn
- dgap_tty_uninit() doesn't match dgap_tty_init() at all. so rename it. It is just used for cleanup when this module is exited or failed to initialize by dgap_init_module. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: rename dgap_finalize_board_init() to dgap_request_irq()Daeseok Youn
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()Daeseok Youn
Pass "brd" to dgap_after_config_loaded() instead of passing "dgap_numboards" and looking up brd again. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: pass "dgap_numboards" as a paramter to dgap_found_board()Daeseok Youn
- Pass "dgap_numboards" to dgap_found_board() instead of using a global variable. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: make dgap_config_buf a local bufferDaeseok Youn
The dgap_config_buf is only used in dgap_firmware_load(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: unwind on error in dgap_tty_register_ports()Daeseok Youn
- The dgap_tty_register_ports() needs to handle if the tty_port_register_device() fails. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: unwind on error in dgap_tty_init()Daeseok Youn
If the kzalloc() fails for channels, it need to handle that error. It should free channels which were already allocated. And also removes the call to dgap_tty_uninit() in dgap_firmware_load(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: remove bogus null test in dgap_tty_init()Daeseok Youn
- The channels array were set to NULL in dgap_found_board(). - Removes redundant null check for channels array in for loop, if one of the channel cannot be allocated, dgap_tty_init() just returns an error. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: unwind on error in dgap_found_board()Daeseok Youn
Adds a label for "kfree(brd)". And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because "brd" will free after failure. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: dgap: remove useless dgap_probe1() functionDaeseok Youn
The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-29Revert "staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()"Greg Kroah-Hartman
This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579 as it was wrong. Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28staging: dgap: Use EIO instead of ENXIOMark Hounschell
Replaces ENXIO with EIO errno Signed-off-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28staging: dgap: Simplify dgap_find_configMark Hounschell
Simplify ugly dgap_find_config function Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28staging: dgap: misc cleanup of NULL conditionalsMark Hounschell
refactors NULL conditionals Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26staging: dgap: move tty_port_init() for serial_ports.Daeseok Youn
If printer_ports which is allocated after serial_ports is failed to allocate, tty_port_init for serial_ports doesn't need anymore. So move this after allocating memory for printer_ports. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()Daeseok Youn
When it failed to allocate for printer_ports, serial_ports can be freed in dgap_tty_uninit(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26staging: dgap: remove unneeded kfree() for ttys in tty_driverDaeseok Youn
In destruct_tty_driver() from put_tty_driver() will free the ttys in tty_driver. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-25Staging: dgap: Fixed iomem accesses in dgap.cPascal COMBES
I changed dereferences from iomem into the adequate ioread function. Signed-off-by: Pascal COMBES <pascom@orange.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-24staging: dgap: Change GFP_ATOMICs to GFP_KERNELMark Hounschell
We don't need to use GFP_ATOMIC at driver load time so use GFP_KERNEL instead. Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-24staging: dgap: Simplify get_altpin and get_useintr functionsMark Hounschell
Simplify dgap_config_get_useintr and dgap_config_get_altpin changing the case statement to an if statement. Signed-off-by: Mark Hounschell <markh@compro.net> Tested-by: Mark Hounschell <markh@compro.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>