path: root/virt
diff options
authorSean Christopherson <sean.j.christopherson@intel.com>2019-02-15 12:48:39 -0800
committerPaolo Bonzini <pbonzini@redhat.com>2019-03-28 17:27:06 +0100
commitddba91801aeb5c160b660caed1800eb3aef403f8 (patch)
tree9b22345e6485bab60e576c0f279d86975d349fcc /virt
parent5e124900c6ebf5dfbe31b7b67073a64b2da14967 (diff)
KVM: Reject device ioctls from processes other than the VM's creator
KVM's API requires thats ioctls must be issued from the same process that created the VM. In other words, userspace can play games with a VM's file descriptors, e.g. fork(), SCM_RIGHTS, etc..., but only the creator can do anything useful. Explicitly reject device ioctls that are issued by a process other than the VM's creator, and update KVM's API documentation to extend its requirements to device ioctls. Fixes: 852b6d57dc7f ("kvm: add device control API") Cc: <stable@vger.kernel.org> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'virt')
1 files changed, 3 insertions, 0 deletions
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index f25aa98a94df..55fe8e20d8fd 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2905,6 +2905,9 @@ static long kvm_device_ioctl(struct file *filp, unsigned int ioctl,
struct kvm_device *dev = filp->private_data;
+ if (dev->kvm->mm != current->mm)
+ return -EIO;
switch (ioctl) {
return kvm_device_ioctl_attr(dev, dev->ops->set_attr, arg);