aboutsummaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2018-10-10 17:18:26 -0700
committerJames Morris <james.morris@microsoft.com>2018-10-10 20:40:22 -0700
commit3f6caaf5ff33073ca1a3a0b82edacab3c57c38f9 (patch)
treeb9276adacfc801ef66b4b524c4f1ef967ef9312a /security
parent9b8c7c14059af801637a818882159145c370d6f1 (diff)
downloadlinux-stericsson-3f6caaf5ff33073ca1a3a0b82edacab3c57c38f9.tar.gz
LSM: Don't ignore initialization failures
LSM initialization failures have traditionally been ignored. We should at least WARN when something goes wrong. Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com> Reviewed-by: John Johansen <john.johansen@canonical.com> Signed-off-by: James Morris <james.morris@microsoft.com>
Diffstat (limited to 'security')
-rw-r--r--security/security.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/security/security.c b/security/security.c
index 395f804f6a91..2055af907eba 100644
--- a/security/security.c
+++ b/security/security.c
@@ -55,10 +55,12 @@ static __initdata bool debug;
static void __init major_lsm_init(void)
{
struct lsm_info *lsm;
+ int ret;
for (lsm = __start_lsm_info; lsm < __end_lsm_info; lsm++) {
init_debug("initializing %s\n", lsm->name);
- lsm->init();
+ ret = lsm->init();
+ WARN(ret, "%s failed to initialize: %d\n", lsm->name, ret);
}
}