path: root/net/rds
diff options
authorGustavo A. R. Silva <gustavo@embeddedor.com>2018-07-25 10:22:27 -0500
committerDavid S. Miller <davem@davemloft.net>2018-07-25 22:37:31 -0700
commitdc66fe43b7ebdb53628dcbc1f8f15de3e000aacf (patch)
tree193a3416a31f937fbe801441c2e922a1f1f07cab /net/rds
parentba7d7e2677c0953b251c36588b15f5f442e59c84 (diff)
rds: send: Fix dead code in rds_sendmsg
Currently, code at label *out* is unreachable. Fix this by updating variable *ret* with -EINVAL, so the jump to *out* can be properly executed instead of directly returning from function. Addresses-Coverity-ID: 1472059 ("Structurally dead code") Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds')
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/send.c b/net/rds/send.c
index 9604e1faa564..18e2b4d3931f 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -1126,7 +1126,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
if (addr4 == htonl(INADDR_ANY) ||
addr4 == htonl(INADDR_BROADCAST) ||
IN_MULTICAST(ntohl(addr4))) {
- return -EINVAL;
+ ret = -EINVAL;
goto out;