path: root/net/rds/recv.c
diff options
authorSowmini Varadhan <sowmini.varadhan@oracle.com>2016-06-30 16:11:18 -0700
committerDavid S. Miller <davem@davemloft.net>2016-07-01 16:45:18 -0400
commit11bb62f7c05240a933dd2e6b3bf3871d99464524 (patch)
treeb5eba2ec540563f39e3932d070f3acbc79b92e20 /net/rds/recv.c
parent8315011ad67670691545ed394968435f0a0bb29e (diff)
RDS: Do not send a pong to an incoming ping with 0 src port
RDS ping messages are sent with a non-zero src port to a zero dst port, so that the rds pong messages can be sent back to the originators src port. However if a confused/malicious sender sends a ping with a 0 src port, we'd have an infinite ping-pong loop. To avoid this, the receiver should ignore ping messages with a 0 src port. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds/recv.c')
1 files changed, 4 insertions, 0 deletions
diff --git a/net/rds/recv.c b/net/rds/recv.c
index b58f50571782..fed53a6c2890 100644
--- a/net/rds/recv.c
+++ b/net/rds/recv.c
@@ -226,6 +226,10 @@ void rds_recv_incoming(struct rds_connection *conn, __be32 saddr, __be32 daddr,
cp->cp_next_rx_seq = be64_to_cpu(inc->i_hdr.h_sequence) + 1;
if (rds_sysctl_ping_enable && inc->i_hdr.h_dport == 0) {
+ if (inc->i_hdr.h_sport == 0) {
+ rdsdebug("ignore ping with 0 sport from 0x%x\n", saddr);
+ goto out;
+ }
rds_send_pong(cp, inc->i_hdr.h_sport);
goto out;