aboutsummaryrefslogtreecommitdiff
path: root/fs/romfs
diff options
context:
space:
mode:
authorWANG Cong <xiyou.wangcong@gmail.com>2007-10-16 23:26:15 -0700
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-10-17 08:42:47 -0700
commit55ca3e796d452d1fd213846ae6ce8bc4d37b54cc (patch)
tree427c69b9ca01c3c259fe71b1d84ee18abbf27979 /fs/romfs
parent0cbc591bf884a5662b2fbb21b5c09fa1c1c7b579 (diff)
downloadlinux-stericsson-55ca3e796d452d1fd213846ae6ce8bc4d37b54cc.tar.gz
fs/romfs/inode.c: trivial improvements
- There are no lists in fs/romfs/inode.c, so using list_entry is a bit confusing. Replace it with container_of. - It is unnecessary to cast the return value of kmem_cache_alloc, since it returns a void* pointer. Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/romfs')
-rw-r--r--fs/romfs/inode.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c
index 7c5e5f573b05..a49cf5b9a195 100644
--- a/fs/romfs/inode.c
+++ b/fs/romfs/inode.c
@@ -92,7 +92,7 @@ static inline unsigned long romfs_maxsize(struct super_block *sb)
static inline struct romfs_inode_info *ROMFS_I(struct inode *inode)
{
- return list_entry(inode, struct romfs_inode_info, vfs_inode);
+ return container_of(inode, struct romfs_inode_info, vfs_inode);
}
static __u32
@@ -555,7 +555,7 @@ static struct kmem_cache * romfs_inode_cachep;
static struct inode *romfs_alloc_inode(struct super_block *sb)
{
struct romfs_inode_info *ei;
- ei = (struct romfs_inode_info *)kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);
+ ei = kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL);
if (!ei)
return NULL;
return &ei->vfs_inode;