path: root/drivers
diff options
authorHimangi Saraogi <himangi774@gmail.com>2014-07-15 22:49:11 +0530
committerMatthew Garrett <matthew.garrett@nebula.com>2014-08-16 01:23:51 -0700
commit959ef6d5def6ff3256f04fbf559eeb7c74d5605a (patch)
tree53e434a2986b21447a44d345207713b8a77b93e0 /drivers
parentbd3c7b9ef7ff26d541393e6c3e985b1c72c277c3 (diff)
WMI: Remove unnecessary null test
This patch removes the null test on block. block is initialized at the beginning of the function to &wblock->gblock. Since wblock is dereferenced prior to the null test, wblock must be a valid pointer, and &wblock->gblock cannot be null. The following Coccinelle script is used for detecting the change: @r@ expression e,f; identifier g,y; statement S1,S2; @@ *e = &f->g <+... f->y ...+> *if (e != NULL || ...) S1 else S2 Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
Diffstat (limited to 'drivers')
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 43d13295e63d..737e56d46f61 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -256,10 +256,6 @@ static acpi_status wmi_method_enable(struct wmi_block *wblock, int enable)
block = &wblock->gblock;
handle = wblock->handle;
- if (!block)
- return AE_NOT_EXIST;
snprintf(method, 5, "WE%02X", block->notify_id);
status = acpi_execute_simple_method(handle, method, enable);