path: root/drivers/gpu/drm/i915/i915_gem.c
diff options
authorDave Gordon <david.s.gordon@intel.com>2016-06-07 09:14:49 +0100
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>2016-06-07 14:21:58 +0100
commite556f7c168c4eeaffad0e53e1c37c27c086d51c6 (patch)
tree483ccd5bb1b6523573f4447993866a3b54b8188e /drivers/gpu/drm/i915/i915_gem.c
parent6bb6285582e0cf9b3a8440e0e714aae5f66d9ce2 (diff)
drm/i915/guc: fix GuC loading/submission check
The last stage of the GuC loader also sanitises the GuC submission settings, so should be called unconditionally (even on platforms without a GuC) to ensure consistent settings; in particular, this prevents any attempt to use GuC submission on GuCless platforms! Also fix error path handling and clarify DRM_INFO fallback message. Signed-off-by: Dave Gordon <david.s.gordon@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem.c')
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 1bfc260c59ad..eae8d7a89d09 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4930,11 +4930,9 @@ i915_gem_init_hw(struct drm_device *dev)
/* We can't enable contexts until all firmware is loaded */
- if (HAS_GUC(dev)) {
- ret = intel_guc_setup(dev);
- if (ret)
- goto out;
- }
+ ret = intel_guc_setup(dev);
+ if (ret)
+ goto out;
* Increment the next seqno by 0x100 so we have a visible break