aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicholas Mc Guire <hofrat@osadl.org>2019-04-13 09:14:21 +0200
committerLinus Walleij <linus.walleij@linaro.org>2019-04-16 13:48:54 +0200
commite2fc3a7ecfb3e8feca246228afa80d83a40b2b65 (patch)
treef15ed23f911ccf385173ed9bb7ffbb6950933d38
parent5f4555be4fcd1918bea1f83decf9ae562fa797b3 (diff)
downloadlinux-stericsson-ux500-cleanups.tar.gz
ARM: ux500: add missing of_node_put()ux500-cleanups
of_find_compatible_node() returns a pointer with refcount incremented so both in the error path as well as after usage in soc_info_populate() respectively actually b8500_read_soc_id() an explicit of_node_put is needed to release backupram. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: commit 18a992787896 ("ARM: ux500: move soc_id driver to drivers/soc") Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/soc/ux500/ux500-soc-id.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/soc/ux500/ux500-soc-id.c b/drivers/soc/ux500/ux500-soc-id.c
index 6c1be74e5fcc..08efb2a2d9f0 100644
--- a/drivers/soc/ux500/ux500-soc-id.c
+++ b/drivers/soc/ux500/ux500-soc-id.c
@@ -203,10 +203,13 @@ static int __init ux500_soc_device_init(void)
ux500_setup_id();
soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);
- if (!soc_dev_attr)
+ if (!soc_dev_attr) {
+ of_node_put(backupram);
return -ENOMEM;
+ }
soc_info_populate(soc_dev_attr, backupram);
+ of_node_put(backupram);
soc_dev = soc_device_register(soc_dev_attr);
if (IS_ERR(soc_dev)) {