aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShanker Donthineni <shankerd@codeaurora.org>2018-01-31 18:03:42 -0600
committerMarc Zyngier <marc.zyngier@arm.com>2018-02-16 13:47:58 +0000
commit21ec30c0ef5234fb1039cc7c7737d885bf875a9e (patch)
treea00ee66a932cce167d87a78b5f8aaa2738e48d06
parentb6dd4d83dc2f78cebc9a7e6e7e4bc2be4d29b94d (diff)
downloadlinux-stericsson-21ec30c0ef5234fb1039cc7c7737d885bf875a9e.tar.gz
irqchip/gic-v3: Use wmb() instead of smb_wmb() in gic_raise_softirq()
A DMB instruction can be used to ensure the relative order of only memory accesses before and after the barrier. Since writes to system registers are not memory operations, barrier DMB is not sufficient for observability of memory accesses that occur before ICC_SGI1R_EL1 writes. A DSB instruction ensures that no instructions that appear in program order after the DSB instruction, can execute until the DSB instruction has completed. Cc: stable@vger.kernel.org Acked-by: Will Deacon <will.deacon@arm.com>, Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
-rw-r--r--drivers/irqchip/irq-gic-v3.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index d71be9a1f9d2..d99cc07903ec 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -688,7 +688,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
* Ensure that stores to Normal memory are visible to the
* other CPUs before issuing the IPI.
*/
- smp_wmb();
+ wmb();
for_each_cpu(cpu, mask) {
u64 cluster_id = MPIDR_TO_SGI_CLUSTER_ID(cpu_logical_map(cpu));