|author||Zach Brown <email@example.com>||2013-05-07 16:18:19 -0700|
|committer||Linus Torvalds <firstname.lastname@example.org>||2013-05-07 18:38:27 -0700|
mm: remove old aio use_mm() comment
Bunch of performance improvements and cleanups Zach Brown and I have been working on. The code should be pretty solid at this point, though it could of course use more review and testing. The results in my testing are pretty impressive, particularly when an ioctx is being shared between multiple threads. In my crappy synthetic benchmark, with 4 threads submitting and one thread reaping completions, I saw overhead in the aio code go from ~50% (mostly ioctx lock contention) to low single digits. Performance with ioctx per thread improved too, but I'd have to rerun those benchmarks. The reason I've been focused on performance when the ioctx is shared is that for a fair number of real world completions, userspace needs the completions aggregated somehow - in practice people just end up implementing this aggregation in userspace today, but if it's done right we can do it much more efficiently in the kernel. Performance wise, the end result of this patch series is that submitting a kiocb writes to _no_ shared cachelines - the penalty for sharing an ioctx is gone there. There's still going to be some cacheline contention when we deliver the completions to the aio ringbuffer (at least if you have interrupts being delivered on multiple cores, which for high end stuff you do) but I have a couple more patches not in this series that implement coalescing for that (by taking advantage of interrupt coalescing). With that, there's basically no bottlenecks or performance issues to speak of in the aio code. This patch: use_mm() is used in more places than just aio. There's no need to mention callers when describing the function. Signed-off-by: Zach Brown <email@example.com> Signed-off-by: Kent Overstreet <firstname.lastname@example.org> Cc: Felipe Balbi <email@example.com> Cc: Greg Kroah-Hartman <firstname.lastname@example.org> Cc: Mark Fasheh <email@example.com> Cc: Joel Becker <firstname.lastname@example.org> Cc: Rusty Russell <email@example.com> Cc: Jens Axboe <firstname.lastname@example.org> Cc: Asai Thambi S P <email@example.com> Cc: Selvan Mani <firstname.lastname@example.org> Cc: Sam Bradshaw <email@example.com> Acked-by: Jeff Moyer <firstname.lastname@example.org> Cc: Al Viro <email@example.com> Cc: Benjamin LaHaise <firstname.lastname@example.org> Reviewed-by: "Theodore Ts'o" <email@example.com> Signed-off-by: Andrew Morton <firstname.lastname@example.org> Signed-off-by: Linus Torvalds <email@example.com>
Diffstat (limited to 'mm')
1 files changed, 0 insertions, 3 deletions
diff --git a/mm/mmu_context.c b/mm/mmu_context.c
index 3dcfaf4ed35..8a8cd0265e5 100644
@@ -14,9 +14,6 @@
* Makes the calling kernel thread take on the specified
* mm context.
- * Called by the retry thread execute retries within the
- * iocb issuer's mm context, so that copy_from/to_user
- * operations work seamlessly for aio.
* (Note: this routine is intended to be called only
* from a kernel thread context)