path: root/drivers/target/loopback
diff options
authorNicholas Bellinger <nab@linux-iscsi.org>2011-11-02 03:33:16 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2011-11-02 15:58:30 +0000
commit88dd9e26d6d3e743f9c7e4562b94b2ad3c2994d3 (patch)
tree452154b4137170de74d4445c5fcbbf62ce2f04fd /drivers/target/loopback
parent5a4c8666c6d576f076a7c6824589cdbb984c0f84 (diff)
target: Make TFO->check_stop_free return free status
This patch converts target_core_fabric_ops->check_stop_free() usage in transport_cmd_check_stop() and associated fabric module usage to return '1' when the passed se_cmd has been released directly within ->check_stop_free(), or return '0' when the passed se_cmd has not been released. This addresses an issue where transport_cmd_finish_abort() -> transport_cmd_check_stop_to_fabric() was leaking descriptors during LUN_RESET for modules using ->check_stop_free(), but not directly releasing se_cmd in all cases. Cc: stable@kernel.org Signed-off-by: Nicholas Bellinger <nab@risingtidesystems.com>
Diffstat (limited to 'drivers/target/loopback')
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 3c9c318f66e..3df1c9b8ae6 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -205,7 +205,7 @@ static int tcm_loop_new_cmd_map(struct se_cmd *se_cmd)
* Called from struct target_core_fabric_ops->check_stop_free()
-static void tcm_loop_check_stop_free(struct se_cmd *se_cmd)
+static int tcm_loop_check_stop_free(struct se_cmd *se_cmd)
* Do not release struct se_cmd's containing a valid TMR
@@ -213,12 +213,13 @@ static void tcm_loop_check_stop_free(struct se_cmd *se_cmd)
* with transport_generic_free_cmd().
if (se_cmd->se_tmr_req)
- return;
+ return 0;
* Release the struct se_cmd, which will make a callback to release
* struct tcm_loop_cmd * in tcm_loop_deallocate_core_cmd()
transport_generic_free_cmd(se_cmd, 0);
+ return 1;
static void tcm_loop_release_cmd(struct se_cmd *se_cmd)