aboutsummaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorStephen Boyd <sboyd@codeaurora.org>2012-03-31 23:41:07 -0700
committerMichal Marek <mmarek@suse.cz>2012-04-02 11:28:17 +0200
commit0eb043d0eec44cd083ea6910b1db2f77eb212ebd (patch)
treefae70f3b77368b9f6397b0ebaacf05d5f4a0ce75 /scripts
parentdd775ae2549217d3ae09363e3edb305d0fa19928 (diff)
downloadlinux-0eb043d0eec44cd083ea6910b1db2f77eb212ebd.tar.gz
Subject: [PATCH] tags.sh: Add missing quotes
When $remove_structs is empty a test for empty string will turn into test -n with no arguments meaning true. Add quotes so an empty string is tested and so that make cscope works again. Reported-and-tested-by: Jike Song <albcamus@gmail.com> Reported-by: Prarit Bhargava <prarit@redhat.com> Acked-by: Yang Bai <hamo.by@gmail.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/tags.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/tags.sh b/scripts/tags.sh
index 0d6004e2065..cf7b12fee57 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -254,6 +254,6 @@ case "$1" in
esac
# Remove structure forward declarations.
-if [ -n $remove_structs ]; then
+if [ -n "$remove_structs" ]; then
LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
fi