path: root/net/sctp
diff options
authorDaniel Borkmann <dborkman@redhat.com>2013-06-14 18:24:06 +0200
committerDavid S. Miller <davem@davemloft.net>2013-06-14 15:38:36 -0700
commitc164b8381496ca797c37671fe510a264412ccae5 (patch)
tree9a1c94d0f34927c943f2246c61cded2eb2595bad /net/sctp
parent405426f6ca8ac2d8d5b1f8eb9285452d44222781 (diff)
net: sctp: minor: remove variable in sctp_init_sock
It's only used at this one time, so we could remove it as well. This is valid and also makes it more explicit/obvious that in case of error the sp->ep is NULL here, i.e. for the sctp_destroy_sock() check that was recently added. Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Acked-by: Vlad Yasevich <vyasevich@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
1 files changed, 2 insertions, 4 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index f631c5ff4db..510dc79a32a 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3862,7 +3862,6 @@ out:
SCTP_STATIC int sctp_init_sock(struct sock *sk)
struct net *net = sock_net(sk);
- struct sctp_endpoint *ep;
struct sctp_sock *sp;
SCTP_DEBUG_PRINTK("sctp_init_sock(sk: %p)\n", sk);
@@ -3971,11 +3970,10 @@ SCTP_STATIC int sctp_init_sock(struct sock *sk)
* change the data structure relationships, this may still
* be useful for storing pre-connect address information.
- ep = sctp_endpoint_new(sk, GFP_KERNEL);
- if (!ep)
+ sp->ep = sctp_endpoint_new(sk, GFP_KERNEL);
+ if (!sp->ep)
return -ENOMEM;
- sp->ep = ep;
sp->hmac = NULL;