|author||Mel Gorman <firstname.lastname@example.org>||2012-01-10 15:07:15 -0800|
|committer||Linus Torvalds <email@example.com>||2012-01-10 16:30:42 -0800|
mm: avoid livelock on !__GFP_FS allocations
Colin Cross reported; Under the following conditions, __alloc_pages_slowpath can loop forever: gfp_mask & __GFP_WAIT is true gfp_mask & __GFP_FS is false reclaim and compaction make no progress order <= PAGE_ALLOC_COSTLY_ORDER These conditions happen very often during suspend and resume, when pm_restrict_gfp_mask() effectively converts all GFP_KERNEL allocations into __GFP_WAIT. The oom killer is not run because gfp_mask & __GFP_FS is false, but should_alloc_retry will always return true when order is less than PAGE_ALLOC_COSTLY_ORDER. In his fix, he avoided retrying the allocation if reclaim made no progress and __GFP_FS was not set. The problem is that this would result in GFP_NOIO allocations failing that previously succeeded which would be very unfortunate. The big difference between GFP_NOIO and suspend converting GFP_KERNEL to behave like GFP_NOIO is that normally flushers will be cleaning pages and kswapd reclaims pages allowing GFP_NOIO to succeed after a short delay. The same does not necessarily apply during suspend as the storage device may be suspended. This patch special cases the suspend case to fail the page allocation if reclaim cannot make progress and adds some documentation on how gfp_allowed_mask is currently used. Failing allocations like this may cause suspend to abort but that is better than a livelock. [firstname.lastname@example.org: Rework fix to be suspend specific] [email@example.com: Move suspended device check to should_alloc_retry] Reported-by: Colin Cross <firstname.lastname@example.org> Signed-off-by: Mel Gorman <email@example.com> Acked-by: David Rientjes <firstname.lastname@example.org> Cc: Minchan Kim <email@example.com> Cc: Pekka Enberg <firstname.lastname@example.org> Cc: KAMEZAWA Hiroyuki <email@example.com> Cc: Andrea Arcangeli <firstname.lastname@example.org> Signed-off-by: Andrew Morton <email@example.com> Signed-off-by: Linus Torvalds <firstname.lastname@example.org>
Diffstat (limited to 'mm/swapfile.c')
1 files changed, 3 insertions, 3 deletions
diff --git a/mm/swapfile.c b/mm/swapfile.c
index b1cd1206072..9520592d423 100644
@@ -667,10 +667,10 @@ int try_to_free_swap(struct page *page)
* original page might be freed under memory pressure, then
* later read back in from swap, now with the wrong data.
- * Hibernation clears bits from gfp_allowed_mask to prevent
- * memory reclaim from writing to disk, so check that here.
+ * Hibration suspends storage while it is writing the image
+ * to disk so check that here.
- if (!(gfp_allowed_mask & __GFP_IO))
+ if (pm_suspended_storage())