path: root/lib/random32.c
diff options
authorAndi Kleen <ak@suse.de>2008-04-03 14:07:02 -0700
committerDavid S. Miller <davem@davemloft.net>2008-04-03 14:07:02 -0700
commit61407f80f72970d52d4339f81c6c3cd03f4ca0f0 (patch)
tree2063040e6e16d5dcc1024c3aedee23195f38b1ba /lib/random32.c
parent84f59370c519449c70dcc813b050f5cbbf0098e7 (diff)
[NET]: srandom32 fixes for networking v2
- Let it update the state of all CPUs. The network stack goes into pains to feed the current IP addresses in, but it is not very effective if that is only done for some random CPU instead of all. So change it to feed bits into all CPUs. I decided to do that lockless because well somewhat random results are ok. v2: Drop rename so that this patch doesn't depend on x86 maintainers Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/random32.c')
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/random32.c b/lib/random32.c
index ec7f81d3fb1..ca87d86992b 100644
--- a/lib/random32.c
+++ b/lib/random32.c
@@ -97,13 +97,18 @@ EXPORT_SYMBOL(random32);
* @seed: seed value
* Add some additional seeding to the random32() pool.
- * Note: this pool is per cpu so it only affects current CPU.
void srandom32(u32 entropy)
- struct rnd_state *state = &get_cpu_var(net_rand_state);
- __set_random32(state, state->s1 ^ entropy);
- put_cpu_var(state);
+ int i;
+ /*
+ * No locking on the CPUs, but then somewhat random results are, well,
+ * expected.
+ */
+ for_each_possible_cpu (i) {
+ struct rnd_state *state = &per_cpu(net_rand_state, i);
+ __set_random32(state, state->s1 ^ entropy);
+ }