path: root/fs/dcache.c
diff options
authorNeilBrown <neilb@suse.de>2012-11-08 16:09:37 -0800
committerAl Viro <viro@zeniv.linux.org.uk>2012-12-20 18:49:10 -0500
commitb911a6bdeef5848c468597d040e3407e0aee04ce (patch)
tree5c71c9c5078634a398d3f0e739e2d8dce732d194 /fs/dcache.c
parent471667391a92bf7bf2cd4ff31a3ad88e5dec934b (diff)
vfs: d_obtain_alias() needs to use "/" as default name.
NFS appears to use d_obtain_alias() to create the root dentry rather than d_make_root. This can cause 'prepend_path()' to complain that the root has a weird name if an NFS filesystem is lazily unmounted. e.g. if "/mnt" is an NFS mount then { cd /mnt; umount -l /mnt ; ls -l /proc/self/cwd; } will cause a WARN message like WARNING: at /home/git/linux/fs/dcache.c:2624 prepend_path+0x1d7/0x1e0() ... Root dentry has weird name <> to appear in kernel logs. So change d_obtain_alias() to use "/" rather than "" as the anonymous name. Signed-off-by: NeilBrown <neilb@suse.de> Cc: Trond Myklebust <Trond.Myklebust@netapp.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/dcache.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dcache.c b/fs/dcache.c
index 1782be3fc3e..19153a0a810 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1559,7 +1559,7 @@ EXPORT_SYMBOL(d_find_any_alias);
struct dentry *d_obtain_alias(struct inode *inode)
- static const struct qstr anonstring = { .name = "" };
+ static const struct qstr anonstring = QSTR_INIT("/", 1);
struct dentry *tmp;
struct dentry *res;