path: root/drivers/char/scx200_gpio.c
diff options
authorJim Cromie <jim.cromie@gmail.com>2006-06-27 02:54:23 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-27 17:32:43 -0700
commitf31000e573da052b6b8bcc21faff520b4e2eda7a (patch)
tree670d5e6e00da615f70d99a950cfe7b8603edad26 /drivers/char/scx200_gpio.c
parent58b087cda1e9e46c7061c2282f92bd8e1970bfe7 (diff)
[PATCH] chardev: GPIO for SCx200 & PC-8736x: use dev_dbg in common module
Use of dev_dbg() and friends is considered good practice. dev_dbg() needs a struct device *devp, but nsc_gpio is only a helper module, so it doesnt have/need its own. To provide devp to the user-modules (scx200 & pc8736x _gpio), we add it to the vtable, and set it during init. Also squeeze nsc_gpio_dump()'s format a little. [ 199.259879] pc8736x_gpio.0: io09: 0x0044 TS OD PUE EDGE LO DEBOUNCE Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/scx200_gpio.c')
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/char/scx200_gpio.c b/drivers/char/scx200_gpio.c
index 442367b3f5d..5a280a33040 100644
--- a/drivers/char/scx200_gpio.c
+++ b/drivers/char/scx200_gpio.c
@@ -35,14 +35,6 @@ static int major = 0; /* default to dynamic major */
module_param(major, int, 0);
MODULE_PARM_DESC(major, "Major device number");
-extern void nsc_gpio_dump(unsigned index);
-extern ssize_t nsc_gpio_write(struct file *file, const char __user *data,
- size_t len, loff_t *ppos);
-extern ssize_t nsc_gpio_read(struct file *file, char __user *buf,
- size_t len, loff_t *ppos);
struct nsc_gpio_ops scx200_access = {
.owner = THIS_MODULE,
.gpio_config = scx200_gpio_configure,
@@ -101,6 +93,9 @@ static int __init scx200_gpio_init(void)
if (rc)
goto undo_malloc;
+ /* nsc_gpio uses dev_dbg(), so needs this */
+ scx200_access.dev = &pdev->dev;
if (major)
rc = register_chrdev_region(dev, num_pins, "scx200_gpio");
else {