aboutsummaryrefslogtreecommitdiff
path: root/drivers/cdrom
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2008-03-26 12:09:00 +0100
committerJens Axboe <jens.axboe@oracle.com>2008-04-21 09:50:07 +0200
commit3c3f4e012ab3471e8bd19220ed897ae9700e5fdd (patch)
tree4c0660ebae592cd0d3ee5e90edc72b086ab6267e /drivers/cdrom
parent17672cf0a7cec57dea4c2a6705bd73114d5e9265 (diff)
downloadlinux-3c3f4e012ab3471e8bd19220ed897ae9700e5fdd.tar.gz
cdrom: cleanup hardcoded error-code
This patch eliminates hardcoded return value of register_cdrom(). It also changes the return value to -EINVAL. It is more appropriate than -2 (-ENOENT) because it is only happen invalid usage of register_cdrom() by broken cdrom driver. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'drivers/cdrom')
-rw-r--r--drivers/cdrom/cdrom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 82c7d212409..fbcf4b3f8d0 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -393,7 +393,7 @@ int register_cdrom(struct cdrom_device_info *cdi)
cdinfo(CD_OPEN, "entering register_cdrom\n");
if (cdo->open == NULL || cdo->release == NULL)
- return -2;
+ return -EINVAL;
if (!banner_printed) {
printk(KERN_INFO "Uniform CD-ROM driver " REVISION "\n");
banner_printed = 1;