aboutsummaryrefslogtreecommitdiff
path: root/crypto/shash.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2012-04-01 20:19:05 -0400
committerDavid S. Miller <davem@davemloft.net>2012-04-02 04:33:42 -0400
commit6662df33f85b87bb29f2ecad124efe7bb2c08e05 (patch)
tree13c8ac420b8d10ec3a7aa9aa7fdaa221e430c9cc /crypto/shash.c
parentb21dddb9dfe50ca1e205faf4b25900895494d25b (diff)
downloadlinux-6662df33f85b87bb29f2ecad124efe7bb2c08e05.tar.gz
crypto: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error prone and make code hard to audit. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/shash.c')
-rw-r--r--crypto/shash.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/crypto/shash.c b/crypto/shash.c
index 21fc12e2378..32067f47e6c 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -534,9 +534,9 @@ static int crypto_shash_report(struct sk_buff *skb, struct crypto_alg *alg)
rhash.blocksize = alg->cra_blocksize;
rhash.digestsize = salg->digestsize;
- NLA_PUT(skb, CRYPTOCFGA_REPORT_HASH,
- sizeof(struct crypto_report_hash), &rhash);
-
+ if (nla_put(skb, CRYPTOCFGA_REPORT_HASH,
+ sizeof(struct crypto_report_hash), &rhash))
+ goto nla_put_failure;
return 0;
nla_put_failure: