aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Paprocki <andrew@ishiboo.com>2008-09-20 10:25:19 +0200
committerJean Delvare <khali@mahadeva.delvare>2008-09-20 10:25:19 +0200
commit859b9ef30cc1bdba4b55327b95b22489bd5591c2 (patch)
tree02ac8658ab2bf6ca5eee6ca2888d93efc7bc5c31
parent13b3c3fa27f8f4ed306ce624f446fab000dd8ee4 (diff)
downloadlinux-859b9ef30cc1bdba4b55327b95b22489bd5591c2.tar.gz
hwmon: (it87) Fix fan tachometer reading in IT8712F rev 0x7 (I)
The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J). The driver was incorrectly attempting to enable 16-bit fan readings on rev 0x7 (I) which led to incorrect RPM values. Signed-off-by: Andrew Paprocki <andrew@ishiboo.com> Tested-by: John Gumb <john.gumb@tandberg.com> Signed-off-by: Jean Delvare <khali@linux-fr.org>
-rw-r--r--drivers/hwmon/it87.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 30cdb095677..f1133081cc4 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -273,10 +273,10 @@ struct it87_data {
static inline int has_16bit_fans(const struct it87_data *data)
{
/* IT8705F Datasheet 0.4.1, 3h == Version G.
- IT8712F Datasheet 0.9.1, section 8.3.5 indicates 7h == Version I.
+ IT8712F Datasheet 0.9.1, section 8.3.5 indicates 8h == Version J.
These are the first revisions with 16bit tachometer support. */
return (data->type == it87 && data->revision >= 0x03)
- || (data->type == it8712 && data->revision >= 0x07)
+ || (data->type == it8712 && data->revision >= 0x08)
|| data->type == it8716
|| data->type == it8718;
}