|author||Roger Tseng <email@example.com>||2015-01-15 15:14:44 +0800|
|committer||Lee Jones <firstname.lastname@example.org>||2015-01-20 12:52:55 +0000|
mfd: rtsx_usb: Fix runtime PM deadlock
sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c acquires dev_mutex and then calls pm_runtime_get_sync() to make sure the device is awake while initializing a newly inserted card. Once it is called during suspending state and explicitly before rtsx_usb_suspend() acquires the same dev_mutex, both routine deadlock and further hang the driver because pm_runtime_get_sync() waits the pending PM operations. Fix this by using an empty suspend method. mmc_core always turns the LED off after a request is done and thus it is ok to remove the only rtsx_usb_turn_off_led() here. Cc: <email@example.com> # v3.16+ Fixes: 730876be2566 ("mfd: Add realtek USB card reader driver") Signed-off-by: Roger Tseng <firstname.lastname@example.org> [Lee: Removed newly unused variable] Signed-off-by: Lee Jones <email@example.com>
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
index dbdd0faeb6c..210d1f85679 100644
@@ -681,21 +681,9 @@ static void rtsx_usb_disconnect(struct usb_interface *intf)
static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message)
- struct rtsx_ucr *ucr =
- (struct rtsx_ucr *)usb_get_intfdata(intf);
dev_dbg(&intf->dev, "%s called with pm message 0x%04x\n",
- * Call to make sure LED is off during suspend to save more power.
- * It is NOT a permanent state and could be turned on anytime later.
- * Thus no need to call turn_on when resunming.