aboutsummaryrefslogtreecommitdiff
path: root/arch/um
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2018-01-27 11:53:57 +0100
committerRichard Weinberger <richard@nod.at>2018-02-19 19:38:51 +0100
commitbe967f7da50b6d08fbb78a5e4408843a9453ac1b (patch)
treecb4acd957b2ddd0799ea338490b24bbda7142eed /arch/um
parent9f3199bcef11caff5e935d0565de0bdb73a3798e (diff)
download96b-common-be967f7da50b6d08fbb78a5e4408843a9453ac1b.tar.gz
um: vector: Fix a memory allocation check
Checking the result of the previous 'kstrdup()' call is expected here, so we should test 'params' and not 'str' (which is known to be non-NULL at this point) Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'arch/um')
-rw-r--r--arch/um/drivers/vector_kern.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index bb83a2d22ac2..063c76b3a215 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -723,7 +723,7 @@ static int vector_config(char *str, char **error_out)
*/
params = kstrdup(params, GFP_KERNEL);
- if (str == NULL) {
+ if (params == NULL) {
*error_out = "vector_config failed to strdup string";
return -ENOMEM;
}