diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2018-10-17 11:18:29 +1100 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2018-10-19 17:25:08 +1100 |
commit | df29347d65bb249d65dc4612ee6ef3bf5cd5fb14 (patch) | |
tree | ad9f5cc30cc0ad14f09b7ba22a66ffc97538fec2 | |
parent | c08110e1e98399eafaca15141e16a8415b087827 (diff) | |
download | 96b-common-df29347d65bb249d65dc4612ee6ef3bf5cd5fb14.tar.gz |
memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes
ERROR: code indent should use tabs where possible
#244: FILE: arch/alpha/kernel/core_wildfire.c:114:
+ hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,$
WARNING: please, no spaces at the start of a line
#244: FILE: arch/alpha/kernel/core_wildfire.c:114:
+ hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,$
ERROR: code indent should use tabs where possible
#246: FILE: arch/alpha/kernel/core_wildfire.c:116:
+ hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,$
WARNING: please, no spaces at the start of a line
#246: FILE: arch/alpha/kernel/core_wildfire.c:116:
+ hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,$
ERROR: space required after that ';' (ctx:VxV)
#380: FILE: arch/ia64/kernel/mca.c:366:
+ (ia64_err_rec_t *)memblock_alloc(size, SMP_CACHE_BYTES);}
^
WARNING: line over 80 characters
#822: FILE: mm/percpu.c:1104:
+ chunk = memblock_alloc(sizeof(struct pcpu_chunk) + BITS_TO_LONGS(region_size >> PAGE_SHIFT),
WARNING: line over 80 characters
#837: FILE: mm/percpu.c:1116:
+ chunk->alloc_map = memblock_alloc(BITS_TO_LONGS(region_bits) * sizeof(chunk->alloc_map[0]),
WARNING: line over 80 characters
#839: FILE: mm/percpu.c:1118:
+ chunk->bound_map = memblock_alloc(BITS_TO_LONGS(region_bits + 1) * sizeof(chunk->bound_map[0]),
WARNING: line over 80 characters
#841: FILE: mm/percpu.c:1120:
+ chunk->md_blocks = memblock_alloc(pcpu_chunk_nr_blocks(chunk) * sizeof(chunk->md_blocks[0]),
total: 3 errors, 6 warnings, 618 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/memblock-stop-using-implicit-alignement-to-smp_cache_bytes.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
-rw-r--r-- | arch/alpha/kernel/core_wildfire.c | 4 | ||||
-rw-r--r-- | mm/percpu.c | 3 |
2 files changed, 4 insertions, 3 deletions
diff --git a/arch/alpha/kernel/core_wildfire.c b/arch/alpha/kernel/core_wildfire.c index 1099a0742dc5..353c03d15442 100644 --- a/arch/alpha/kernel/core_wildfire.c +++ b/arch/alpha/kernel/core_wildfire.c @@ -111,9 +111,9 @@ wildfire_init_hose(int qbbno, int hoseno) * ??? We ought to scale window 3 memory. * */ - hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000, + hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000, SMP_CACHE_BYTES); - hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000, + hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000, SMP_CACHE_BYTES); pci = WILDFIRE_pci(qbbno, hoseno); diff --git a/mm/percpu.c b/mm/percpu.c index b05eca6a52d7..db86282fd024 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1101,7 +1101,8 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr, region_size = ALIGN(start_offset + map_size, lcm_align); /* allocate chunk */ - chunk = memblock_alloc(sizeof(struct pcpu_chunk) + BITS_TO_LONGS(region_size >> PAGE_SHIFT), + chunk = memblock_alloc(sizeof(struct pcpu_chunk) + + BITS_TO_LONGS(region_size >> PAGE_SHIFT), SMP_CACHE_BYTES); INIT_LIST_HEAD(&chunk->list); |