aboutsummaryrefslogtreecommitdiff log msg author committer range
path: root/lib/reciprocal_div.c
diff options
 context: 12345678910152025303540 space: includeignore mode: unifiedssdiffstat only
author committer Eric Dumazet 2006-12-13 00:34:27 -0800 Linus Torvalds 2006-12-13 09:05:49 -0800 6a2d7a955d8de6cb19ed9cd194b3c83008a22c32 (patch) dc440341412a45a7c1f363dcaa1505fe711eadec /lib/reciprocal_div.c 02a0e53d8227aff5e62e0433f82c12c1c2805fd6 (diff) linux-stericsson-6a2d7a955d8de6cb19ed9cd194b3c83008a22c32.tar.gz
[PATCH] SLAB: use a multiply instead of a divide in obj_to_index()
When some objects are allocated by one CPU but freed by another CPU we can consume lot of cycles doing divides in obj_to_index(). (Typical load on a dual processor machine where network interrupts are handled by one particular CPU (allocating skbufs), and the other CPU is running the application (consuming and freeing skbufs)) Here on one production server (dual-core AMD Opteron 285), I noticed this divide took 1.20 % of CPU_CLK_UNHALTED events in kernel. But Opteron are quite modern cpus and the divide is much more expensive on oldest architectures : On a 200 MHz sparcv9 machine, the division takes 64 cycles instead of 1 cycle for a multiply. Doing some math, we can use a reciprocal multiplication instead of a divide. If we want to compute V = (A / B) (A and B being u32 quantities) we can instead use : V = ((u64)A * RECIPROCAL(B)) >> 32 ; where RECIPROCAL(B) is precalculated to ((1LL << 32) + (B - 1)) / B Note : I wrote pure C code for clarity. gcc output for i386 is not optimal but acceptable : mull 0x14(%ebx) mov %edx,%eax // part of the >> 32 xor %edx,%edx // useless mov %eax,(%esp) // could be avoided mov %edx,0x4(%esp) // useless mov (%esp),%ebx [akpm@osdl.org: small cleanups] Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Cc: Christoph Lameter <clameter@sgi.com> Cc: David Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'lib/reciprocal_div.c')
-rw-r--r--lib/reciprocal_div.c9
1 files changed, 9 insertions, 0 deletions
 diff --git a/lib/reciprocal_div.c b/lib/reciprocal_div.cnew file mode 100644index 000000000000..6a3bd48fa2a0--- /dev/null+++ b/lib/reciprocal_div.c@@ -0,0 +1,9 @@+#include +#include ++u32 reciprocal_value(u32 k)+{+ u64 val = (1LL << 32) + (k - 1);+ do_div(val, k);+ return (u32)val;+}