path: root/lib/dma-debug.c
diff options
authorDan Carpenter <dan.carpenter@oracle.com>2012-06-27 12:08:55 +0300
committerJoerg Roedel <joerg.roedel@amd.com>2012-07-02 12:11:40 +0200
commit68ee6d22376411f8ec668413f1b632a34192a807 (patch)
tree04d58831702e693d69702787fbe8538499086bd0 /lib/dma-debug.c
parent8f53dc724a83a0082184fa27df80c25c7df47340 (diff)
dma-debug: debugfs_create_bool() takes a u32 pointer
Even though it has "bool" in the name, you have pass a u32 pointer to debugfs_create_bool(). Otherwise you get memory corruption in write_file_bool(). Fortunately in this case the corruption happens in an alignment hole between variables so it doesn't cause any problems. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Diffstat (limited to 'lib/dma-debug.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 518aea714d21..66ce41489133 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -78,7 +78,7 @@ static LIST_HEAD(free_entries);
static DEFINE_SPINLOCK(free_entries_lock);
/* Global disable flag - will be set in case of an error */
-static bool global_disable __read_mostly;
+static u32 global_disable __read_mostly;
/* Global error count */
static u32 error_count;
@@ -657,7 +657,7 @@ static int dma_debug_fs_init(void)
global_disable_dent = debugfs_create_bool("disabled", 0444,
- (u32 *)&global_disable);
+ &global_disable);
if (!global_disable_dent)
goto out_err;