|author||Paul E. McKenney <firstname.lastname@example.org>||2017-01-18 02:53:44 -0800|
|committer||Paul E. McKenney <email@example.com>||2017-04-18 11:42:36 -0700|
mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU
A group of Linux kernel hackers reported chasing a bug that resulted from their assumption that SLAB_DESTROY_BY_RCU provided an existence guarantee, that is, that no block from such a slab would be reallocated during an RCU read-side critical section. Of course, that is not the case. Instead, SLAB_DESTROY_BY_RCU only prevents freeing of an entire slab of blocks. However, there is a phrase for this, namely "type safety". This commit therefore renames SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU in order to avoid future instances of this sort of confusion. Signed-off-by: Paul E. McKenney <firstname.lastname@example.org> Cc: Christoph Lameter <email@example.com> Cc: Pekka Enberg <firstname.lastname@example.org> Cc: David Rientjes <email@example.com> Cc: Joonsoo Kim <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com> Cc: <firstname.lastname@example.org> Acked-by: Johannes Weiner <email@example.com> Acked-by: Vlastimil Babka <firstname.lastname@example.org> [ paulmck: Add comments mentioning the old name, as requested by Eric Dumazet, in order to help people familiar with the old name find the new one. ] Acked-by: David Rientjes <email@example.com>
Diffstat (limited to 'fs/signalfd.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/signalfd.c b/fs/signalfd.c
index 270221fcef42..7e3d71109f51 100644
@@ -38,7 +38,7 @@ void signalfd_cleanup(struct sighand_struct *sighand)
* The lockless check can race with remove_wait_queue() in progress,
* but in this case its caller should run under rcu_read_lock() and
- * sighand_cachep is SLAB_DESTROY_BY_RCU, we can safely return.
+ * sighand_cachep is SLAB_TYPESAFE_BY_RCU, we can safely return.