path: root/fs/ext4/inline.c
diff options
authorEric Biggers <ebiggers@google.com>2017-03-15 14:52:02 -0400
committerTheodore Ts'o <tytso@mit.edu>2017-03-15 14:52:02 -0400
commitb9cf625d6ecde0d372e23ae022feead72b4228a6 (patch)
tree26d37735efe205c438165802fc0b64c43b4cbfb1 /fs/ext4/inline.c
parentcab7076a185e1e27f6879325e4da762424c3f1c9 (diff)
ext4: mark inode dirty after converting inline directory
If ext4_convert_inline_data() was called on a directory with inline data, the filesystem was left in an inconsistent state (as considered by e2fsck) because the file size was not increased to cover the new block. This happened because the inode was not marked dirty after i_disksize was updated. Fix this by marking the inode dirty at the end of ext4_finish_convert_inline_dir(). This bug was probably not noticed before because most users mark the inode dirty afterwards for other reasons. But if userspace executed FS_IOC_SET_ENCRYPTION_POLICY with invalid parameters, as exercised by 'kvm-xfstests -c adv generic/396', then the inode was never marked dirty after updating i_disksize. Cc: stable@vger.kernel.org # 3.10+ Fixes: 3c47d54170b6a678875566b1b8d6dcf57904e49b Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/inline.c')
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 30a9f210d1e3..375fb1c05d49 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1169,10 +1169,9 @@ static int ext4_finish_convert_inline_dir(handle_t *handle,
err = ext4_handle_dirty_dirent_node(handle, inode, dir_block);
if (err)
- goto out;
+ return err;
- return err;
+ return ext4_mark_inode_dirty(handle, inode);
static int ext4_convert_inline_data_nolock(handle_t *handle,