path: root/scripts
diff options
authorFabian Frederick <>2015-04-14 15:42:34 -0700
committerLinus Torvalds <>2015-04-14 16:48:56 -0700
commit5017335d6d8c1fc3bbc04f80785440885f305879 (patch)
treebbf0b68bd35ca89f54c42dd50efc41d893f4ef5f /scripts
parent97534127012f0e396eddea4691f4c9b170aed74b (diff)
scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning
if()/BUG conversion to BUG_ON must be avoided when there's side effect in condition. The reason being BUG_ON won't execute the condition when CONFIG_BUG is not defined. With inspiration from Bruce Fields. Signed-off-by: Fabian Frederick <> Suggested-by: Julia Lawall <> Acked-by: Julia Lawall <> Cc: J. Bruce Fields <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'scripts')
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci
index 3b7eec24fb5a..27c97f1f2767 100644
--- a/scripts/coccinelle/misc/bugon.cocci
+++ b/scripts/coccinelle/misc/bugon.cocci
@@ -57,6 +57,6 @@[0], "WARNING use BUG_ON")
p << r.p;
-msg="WARNING: Use BUG_ON"
+msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)"[0], msg)