path: root/drivers/pinctrl
diff options
authorFrancesco VIRLINZI <>2015-01-05 11:04:13 +0100
committerLinus Walleij <>2015-01-07 10:43:41 +0100
commit96d16c3088a924a44175d2923cc0eafa0d8bbecc (patch)
tree03308ef2873f09f6e45e491e0d1e788fa4e99e0e /drivers/pinctrl
parentf2dd028c2632d107c26b1daed543d9efd4f0decd (diff)
pinctrl: st: avoid multiple mutex lock
Using the sysfs inteface to inspect the pins configuration the system can walk around a path which acquires the same mutex twice. On STiH407 platform, for example : cat /sys/kernel/debug/pinctrl/ hangs the kernel and never returns. With this patch the mutex is temporary freed. Signed-off-by: Francesco Virlinzi <> Signed-off-by: Patrice Chotard <> Signed-off-by: Linus Walleij <>
Diffstat (limited to 'drivers/pinctrl')
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 7c9d51382248..87570e68deed 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1012,8 +1012,10 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev,
struct seq_file *s, unsigned pin_id)
unsigned long config;
- st_pinconf_get(pctldev, pin_id, &config);
+ mutex_unlock(&pctldev->mutex);
+ st_pinconf_get(pctldev, pin_id, &config);
+ mutex_lock(&pctldev->mutex);
seq_printf(s, "[OE:%ld,PU:%ld,OD:%ld]\n"